Skip to content

Comments

gh-133146: Add the old public get_value method to documentation and refactor code.#133301

Merged
gpshead merged 8 commits intopython:mainfrom
YvesDup:sem-macosx-multiprocessing-get_value
Nov 29, 2025
Merged

gh-133146: Add the old public get_value method to documentation and refactor code.#133301
gpshead merged 8 commits intopython:mainfrom
YvesDup:sem-macosx-multiprocessing-get_value

Conversation

@YvesDup
Copy link
Contributor

@YvesDup YvesDup commented May 2, 2025 •
edited by gpshead
Loading

  1. Update documentation of multiprocessing.Lockclass.
  2. Refactor code to mask calls to the private _semlock attribute of multiprocessing.Sempahore class.
    The multiprocessing.BoundedSempahore, multiprocessing.Condition and multiprocessing.Queue classes will update.

📚 Documentation preview 📚: https://cpython-previews--133301.org.readthedocs.build/

Closes #133146

@YvesDup YvesDup requested a review from gpshead as a code owner May 2, 2025 14:26
@bedevere-app bedevere-app bot mentioned this pull request May 2, 2025
Closed
@YvesDup YvesDup changed the title gh-133146: Add the older public get_value method to documantation and refactor code. gh-133146: Add the old public get_value method to documantation and refactor code. May 2, 2025
@YvesDup YvesDup changed the title gh-133146: Add the old public get_value method to documantation and refactor code. gh-133146: Add the old public get_value method to documentation and refactor code. May 2, 2025
YvesDup
YvesDup commented May 3, 2025
View reviewed changes
@YvesDup
Copy link
Contributor Author

YvesDup commented Jun 9, 2025 •
edited
Loading

Why this method is undocumented ?
See here #84974

Updated: I only suggest to refactor code

@gpshead gpshead added the docs Documentation in the Doc dir label Nov 29, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Nov 29, 2025
@gpshead
reword news
c5eab2e 
don't describe documentation updates.  just note that some internal details changed a bit.
@gpshead gpshead enabled auto-merge (squash) November 29, 2025 21:39
@gpshead gpshead disabled auto-merge November 29, 2025 21:42
@gpshead gpshead enabled auto-merge (squash) November 29, 2025 21:43
@gpshead gpshead added the needs backport to 3.14 bugs and security fixes label Nov 29, 2025
@gpshead gpshead merged commit db098a4 into python:main Nov 29, 2025
48 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Nov 29, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 29, 2025

Thanks @YvesDup for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Nov 29, 2025

Sorry, @YvesDup and @gpshead, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker db098a475a47b16d25c88d95dbcf0c6572c68576 3.14

hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 30, 2025
@YvesDup @hugovk
[3.14] pythongh-133146: Add the old public get_value method to docu…
ecab12a 
…mentation and refactor code. (pythonGH-133301)

also uses it within the internals in a few places.
(cherry picked from commit db098a4)

Co-authored-by: Duprat <yduprat@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 30, 2025

GH-142110 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 30, 2025
gpshead pushed a commit that referenced this pull request Nov 30, 2025
@hugovk @YvesDup
[3.14] gh-133146: Add the old public get_value method to documentat…
b95d16a 
…ion and refactor code. (GH-133301) (#142110)

also uses it within the internals in a few places.
(cherry picked from commit db098a4)

Co-authored-by: Duprat <yduprat@gmail.com>
@YvesDup
Copy link
Contributor Author

YvesDup commented Dec 1, 2025 •
edited
Loading

Thank you @gpshead for approving this PR.

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@YvesDup @StanFromIreland
pythongh-133146: Add the old public get_value method to documentati…
a19fde2 
…on and refactor code. (pythonGH-133301)

also uses it within the internals in a few places.
@YvesDup YvesDup deleted the sem-macosx-multiprocessing-get_value branch February 9, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@gpshead gpshead

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document the public multiprocessing.[Bounded]Semaphore.get_value method and refactor code

2 participants

@YvesDup @gpshead